Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-7126][CORE][1.2] Fix issue that unsupported join type in BNLJ is not fallback #7569

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[GLUTEN-7126][CORE][1.2] Fix issue that unsupported join type in BNLJ is not fallback #7569

merged 1 commit into from
Nov 22, 2024

Conversation

ccat3z
Copy link
Contributor

@ccat3z ccat3z commented Oct 17, 2024

BNLJ with unsupported join type throw the following IllegalArgumentException, which fixed in #6290. Backport to gluten 1.2.

java.lang.IllegalArgumentException: VeloxBroadcastNestedLoopJoinExecTransformer not take LeftAnti as the JoinType
        at org.apache.gluten.execution.BroadcastNestedLoopJoinExecTransformer.output(BroadcastNestedLoopJoinExecTransformer.scala:83)
        at org.apache.spark.sql.catalyst.plans.QueryPlan.schema$lzycompute(QueryPlan.scala:375)
        at org.apache.spark.sql.catalyst.plans.QueryPlan.schema(QueryPlan.scala:375)
        at org.apache.gluten.extension.GlutenPlan.doValidate(GlutenPlan.scala:72)
        at org.apache.gluten.extension.GlutenPlan.doValidate$(GlutenPlan.scala:70)
        at org.apache.gluten.execution.BroadcastNestedLoopJoinExecTransformer.doValidate(BroadcastNestedLoopJoinExecTransformer.scala:35)
        at org.apache.gluten.extension.columnar.AddFallbackTagRule.addFallbackTag(FallbackTagRule.scala:417)
        at org.apache.gluten.extension.columnar.AddFallbackTagRule.$anonfun$apply$4(FallbackTagRule.scala:305)
        at org.apache.gluten.extension.columnar.AddFallbackTagRule.$anonfun$apply$4$adapted(FallbackTagRule.scala:305)
        at org.apache.spark.sql.catalyst.trees.TreeNode.foreachUp(TreeNode.scala:254)
        at org.apache.spark.sql.catalyst.trees.TreeNode.$anonfun$foreachUp$1(TreeNode.scala:253)
        at org.apache.spark.sql.catalyst.trees.TreeNode.$anonfun$foreachUp$1$adapted(TreeNode.scala:253)
        at scala.collection.immutable.List.foreach(List.scala:392)
        at org.apache.spark.sql.catalyst.trees.TreeNode.foreachUp(TreeNode.scala:253)
        at org.apache.spark.sql.catalyst.trees.TreeNode.$anonfun$foreachUp$1(TreeNode.scala:253)
        at org.apache.spark.sql.catalyst.trees.TreeNode.$anonfun$foreachUp$1$adapted(TreeNode.scala:253)

@github-actions GitHub Actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@ccat3z ccat3z changed the title [GLUTEN-1.2] Fix issue that unsupported join type in BNLJ is not fallback [CORE][1.2] Fix issue that unsupported join type in BNLJ is not fallback Oct 21, 2024
@ccat3z
Copy link
Contributor Author

ccat3z commented Oct 21, 2024 •
edited
Loading

@weiting-chen Could you help review this PR?

@zhouyuan zhouyuan changed the title [CORE][1.2] Fix issue that unsupported join type in BNLJ is not fallback [GLUTEN-7126][CORE][1.2] Fix issue that unsupported join type in BNLJ is not fallback Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

#7126

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@weiting-chen
Copy link
Contributor

there is one fail during CK UT test, re-trigger to check.

@weiting-chen weiting-chen self-requested a review November 19, 2024 08:46
weiting-chen
weiting-chen approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@weiting-chen weiting-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@weiting-chen weiting-chen mentioned this pull request Nov 20, 2024
Open
37 tasks
@weiting-chen weiting-chen merged commit ca09a60 into apache:branch-1.2 Nov 22, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiting-chen weiting-chen weiting-chen approved these changes

@zhouyuan zhouyuan zhouyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccat3z @weiting-chen @zhouyuan