Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-8018][VL] Support adjusting stage resource profile dynamically #8209

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[GLUTEN-8018][VL] Support adjusting stage resource profile dynamically #8209

wants to merge 3 commits into from
+360 −0

Conversation

zjuwangg
Copy link
Contributor

What changes were proposed in this pull request?

It's a follow PR of #8195 and demonstrate how to adjust resource profile through Rule.

How was this patch tested?

Unit test will be updated soon.

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions github-actions bot added CORE works for Gluten Core VELOX CLICKHOUSE labels Dec 11, 2024
@github-actions GitHub Actions
Copy link

#8018

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@zjuwangg zjuwangg mentioned this pull request Dec 11, 2024
Merged
@zhztheplayer zhztheplayer changed the title [GLUTEN-8018]Introduce GlutenAutoAdjustStageResourceProfileRule to auto adjust stage resource profile [GLUTEN-8018] Introduce GlutenAutoAdjustStageResourceProfileRule to auto adjust stage resource profile Dec 12, 2024
@zhztheplayer
Copy link
Member

Thank you for splitting the PR into 2. Let's discuss in #8195 before moving forward to this one.

@PHILO-HE PHILO-HE changed the title [GLUTEN-8018] Introduce GlutenAutoAdjustStageResourceProfileRule to auto adjust stage resource profile [GLUTEN-8018][CORE] Support adjust stage resource profile dynamically Dec 17, 2024
@PHILO-HE PHILO-HE changed the title [GLUTEN-8018][CORE] Support adjust stage resource profile dynamically [GLUTEN-8018][CORE] Support adjusting stage resource profile dynamically Dec 17, 2024
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

zhztheplayer
zhztheplayer reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@zhztheplayer zhztheplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests in this PR? Since the feature seems functional to users after the change. Thanks!

Also, could change [CORE] to [VL] in PR title if this is not ready for CH use yet.

backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxRuleApi.scala Outdated Show resolved Hide resolved
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxRuleApi.scala Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@zjuwangg zjuwangg changed the title [GLUTEN-8018][CORE] Support adjusting stage resource profile dynamically [GLUTEN-8018][VL] Support adjusting stage resource profile dynamically Dec 18, 2024
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhztheplayer zhztheplayer zhztheplayer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CORE works for Gluten Core VELOX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zjuwangg @zhztheplayer