Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphTxn can incorrectly attempt to create a nested transaction on find() calls #2086

Closed
rvesse opened this issue Nov 13, 2023 · 0 comments
Closed
Labels
bug Jena4 Item related to Jena4 but not Jena5.

Comments

@rvesse
Copy link
Member

rvesse commented Nov 13, 2023

Version

4.10.0

What happened?

A GraphTxn.find() call will fail if the GraphTxn is already in a transaction, PR #1964 made changes to address #1961 which attempted to make GraphTxn.find() behaviour transactionally consistent and thread-safe.

However the check at https://github.com/apache/jena/blob/jena-4.10.0/jena-arq/src/main/java/org/apache/jena/sparql/graph/GraphTxn.java#L118 was not inverted as it should be, so rather than only creating a transaction when one did not exist it instead did the opposite. This has already been fixed on main - https://github.com/apache/jena/blob/main/jena-arq/src/main/java/org/apache/jena/sparql/graph/GraphTxn.java#L118

Ideally a fix needs to be back ported to jena4 branch and a point release created to address this as otherwise GraphTxn.find() is broken for 4.10.0

gh-1964-stacktrace

Relevant output and stacktrace

No response

Are you interested in making a pull request?

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Jena4 Item related to Jena4 but not Jena5.
Projects
None yet
Development

No branches or pull requests

2 participants