KAFKA-18064: SASL mechanisms that do support neihter integrity nor co… #17901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!isComplete()) | ||
| throw new IllegalStateException("Authentication exchange has not completed"); | ||
| return Arrays.copyOfRange(incoming, offset, offset + len); | ||
| throw new IllegalStateException("Mechanism does not support integrity nor confidentality"); |
There was a problem hiding this comment.
Should we perhaps alter the message within IllegalStateException depending on whether the authentication is completed or not and add the name of the mechanism as well? Similar to how the JDK implementation does it for PlainClient
There was a problem hiding this comment.
Thanks, re-written to match the JDK behaviour and be more consistent with the existing code.
| if (!isComplete()) | ||
| throw new IllegalStateException("Authentication exchange has not completed"); | ||
| return Arrays.copyOfRange(outgoing, offset, offset + len); | ||
| throw new IllegalStateException("Mechanism does not support integrity nor confidentality"); |
There was a problem hiding this comment.
I think you missed the change in OAuthBearerSaslServer
…nfidentality should throw exception on wrap/unwrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nfidentality should throw exception on wrap/unwrap
The current implementation does not implement wrap/unwrap correctly.
This may cause security issues, if the code using the mechanisms does
not check for QOP correctly.
No testing done, if this breaks something, then calling code must be fixed.
Committer Checklist (excluded from commit message)