KAFKA-15561 [2/N]: Background event and subscription state changes for RE2J pattern #17918
+214
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, next PR will contain the integration with the HB and integration tests. |
lianetm
commented
Nov 22, 2024
| @@ -108,13 +112,21 @@ private enum SubscriptionType { | |||
| public synchronized String toString() { | |||
| return "SubscriptionState{" + | |||
| "type=" + subscriptionType + | |||
| ", subscribedPattern=" + subscribedPattern + | |||
| ", subscribedPattern=" + subscribedPatternInUse() + | |||
There was a problem hiding this comment.
I'm intentionally avoiding differentiating the 2 patterns output thinking that it will help have a smooth transition when we end up deprecating/removing the old pattern in the future. Makes sense?
|
Comment regarding the mixed subscription error msg in It's truly not clearly stating that we don't allow pattern and re2j pattern together (we don't), but I intentionally didn't change it wondering if it's more of a hassle given that this is expected to be a transition period until we deprecate (eventually remove) the old regex, and then the current msg will be fully accurate as it is. Let me know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes: