KAFKA-17299: add unit tests for previous fix #17919
Open
+164
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apache#17899 fixed the issue, but did not add any unit tests.
mjsax
commented
Nov 23, 2024
| record = queue.poll(wallClockTime); | ||
|
|
||
| if (record != null) { | ||
| --totalBuffered; | ||
| totalBuffered -= (oldSize - queue.size()); |
There was a problem hiding this comment.
This is a follow up fix: when we skip more than one corrupted record, we don't update the buffer size correctly.
mjsax
commented
Nov 23, 2024
| private final TopicPartition partition1 = new TopicPartition(topic1, 1); | ||
| private final TopicPartition partition2 = new TopicPartition(topic2, 1); | ||
| private final TopicPartition partition1 = new TopicPartition(topic1, 0); | ||
| private final TopicPartition partition2 = new TopicPartition(topic2, 0); |
There was a problem hiding this comment.
Side cleanup -- not sure why we use partition number 1, but not 0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17899 fixed the issue, but did not add any unit tests.