Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Arrays.mismatch in FSTCompiler#add. #13924

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use Arrays.mismatch in FSTCompiler#add. #13924

wants to merge 1 commit into from
+8 −7

Conversation

vsop-479
Copy link
Contributor

Description

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!

@github-actions github-actions bot added the Stale label Nov 1, 2024
dungba88
dungba88 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@dungba88 dungba88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the change does look clearer and simpler.

@vsop-479
Copy link
Contributor Author

Thanks for your review, @dungba88 .

@github-actions github-actions bot removed the Stale label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dungba88 dungba88 dungba88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsop-479 @dungba88