Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The icon for running a test method is not displayed correctly in the dark editor theme #8151

Open
troizet opened this issue Jan 14, 2025 · 5 comments · May be fixed by #8114
Open

The icon for running a test method is not displayed correctly in the dark editor theme #8151

troizet opened this issue Jan 14, 2025 · 5 comments · May be fixed by #8114
Labels
Editor kind:bug Bug report or fix UI User Interface

Comments

@troizet
Copy link
Collaborator

troizet commented Jan 14, 2025

Apache NetBeans version

Apache NetBeans 24

What happened

The icon for running a test method is not displayed correctly in the dark editor theme:

Image

Language / Project Type / NetBeans Component

No response

How to reproduce

  • Select a dark theme for the editor in:
    Tools -> Options -> Fonts and Colors -> Profile.

In the example, FlatLaf Dark profile is selected.

  • Open any test file.

Did this work correctly in an earlier version?

No / Don't know

Operating System

Ubuntu 22.04.5 LTS

JDK

OpenJDK Runtime Environment 17.0.13+11-Ubuntu-2ubuntu122.04

Apache NetBeans packaging

Apache NetBeans binary zip

Anything else

No response

Are you willing to submit a pull request?

No

@troizet troizet added Editor kind:bug Bug report or fix needs:triage Requires attention from one of the committers UI User Interface labels Jan 14, 2025
@neilcsmith-net
Copy link
Member

Have you tried with a recent dev build? An SVG icon was added for this last week so this might already be fixed.

@mbien
Copy link
Member

mbien commented Jan 14, 2025

I believe it will use the bitmap icon until the image loading/composition refactoring PRs are merged. I run a dev build right now and can reproduce it. I always thought this should represent that you can choose between run and debug - but the light theme renders it properly so it might be indeed a bug.

some alpha blending cutoff issue?

@mbien
Copy link
Member

mbien commented Jan 14, 2025

i think this confirms its alpha blending (or the lack of any blending ;)):

Image

so this will be likely fixed with one of @eirikbakke svg / img loading PRs which are in the queue.

@mbien mbien removed the needs:triage Requires attention from one of the committers label Jan 14, 2025
@eirikbakke
Copy link
Contributor

so this will be likely fixed with one of @eirikbakke svg / img loading PRs which are in the queue.

Yeah, I think it will! The revision to #8114 is ready to be reviewed again, and once that PR is merged I will revise #8109 to simplify by using new ImageUtilities methods.

@mbien
Copy link
Member

mbien commented Jan 14, 2025

linked the PR with this issue, looks good:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editor kind:bug Bug report or fix UI User Interface
Projects
None yet
4 participants