-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFICPP-2137 Rewrite MiNiFi Controller to use asio #1595
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordgamez
force-pushed
the
MINIFICPP-2137
branch
from
June 27, 2023 12:57
b170704
to
206c3f3
Compare
martinzink
reviewed
Jun 30, 2023
martinzink
reviewed
Jun 30, 2023
martinzink
reviewed
Jul 3, 2023
8 tasks
martinzink
reviewed
Jul 4, 2023
martinzink
approved these changes
Jul 12, 2023
lordgamez
force-pushed
the
MINIFICPP-2137
branch
from
July 17, 2023 13:48
b0301bc
to
2b4605a
Compare
fgerlits
reviewed
Jul 21, 2023
lordgamez
force-pushed
the
MINIFICPP-2137
branch
from
July 24, 2023 09:23
45c6779
to
0555472
Compare
fgerlits
approved these changes
Jul 24, 2023
szaszm
reviewed
Jul 25, 2023
szaszm
reviewed
Aug 1, 2023
lordgamez
force-pushed
the
MINIFICPP-2137
branch
from
August 1, 2023 14:10
877936f
to
c8d0aed
Compare
lordgamez
force-pushed
the
MINIFICPP-2137
branch
from
August 3, 2023 08:43
ad6de60
to
f10d6e0
Compare
szaszm
reviewed
Aug 3, 2023
adamdebreceni
approved these changes
Aug 8, 2023
lordgamez
force-pushed
the
MINIFICPP-2137
branch
from
August 16, 2023 11:26
0fef6eb
to
4830868
Compare
szaszm
approved these changes
Aug 16, 2023
lordgamez
force-pushed
the
MINIFICPP-2137
branch
from
August 17, 2023 07:34
4830868
to
97dc172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2137
Note: depends on #1583 as there was a compile issue with LibreSSL on Windows that does not appear with OpenSSL. It seems to be due to some Windows specific macro definition. If we plan to move to OpenSSL I don't think it's worth debugging.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.