Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-2137 Rewrite MiNiFi Controller to use asio #1595

Closed
wants to merge 13 commits into from

Conversation

lordgamez
Copy link
Contributor

https://issues.apache.org/jira/browse/MINIFICPP-2137

Note: depends on #1583 as there was a compile issue with LibreSSL on Windows that does not appear with OpenSSL. It seems to be due to some Windows specific macro definition. If we plan to move to OpenSSL I don't think it's worth debugging.

2023-06-23T15:41:12.8423242Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(194): error C2143: syntax error: missing ')' before 'constant'
2023-06-23T15:41:12.8558554Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(194): error C2143: syntax error: missing ';' before 'constant'
2023-06-23T15:41:12.8582850Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(194): error C2059: syntax error: ')'
2023-06-23T15:41:12.8727617Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(194): error C2238: unexpected token(s) preceding ';'
2023-06-23T15:41:12.8746940Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(202): error C2143: syntax error: missing ')' before 'constant'
2023-06-23T15:41:12.8752091Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(202): error C2143: syntax error: missing ';' before 'constant'
2023-06-23T15:41:12.8754426Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(202): error C2059: syntax error: ')'
2023-06-23T15:41:12.8876950Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(202): error C2238: unexpected token(s) preceding ';'
2023-06-23T15:41:12.9189256Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(231): error C2143: syntax error: missing ')' before 'constant'
2023-06-23T15:41:12.9220842Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(231): error C2143: syntax error: missing ';' before 'constant'
2023-06-23T15:41:12.9268061Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(231): error C2059: syntax error: ')'
2023-06-23T15:41:12.9314784Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(231): error C2238: unexpected token(s) preceding ';'
2023-06-23T15:41:12.9378837Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(657): error C2059: syntax error: '('
2023-06-23T15:41:12.9710560Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(657): error C2143: syntax error: missing ',' before '*'
2023-06-23T15:41:12.9786697Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(657): error C2143: syntax error: missing ';' before ')'
2023-06-23T15:41:12.9789902Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(657): error C2059: syntax error: ')'
2023-06-23T15:41:12.9918377Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(837): error C2065: 'nm': undeclared identifier
2023-06-23T15:41:12.9962902Z D:\a\nifi-minifi-cpp\b\thirdparty\libressl-install\include\openssl/x509v3.h(837): error C2226: syntax error: unexpected type 'stack_st_CONF_VALUE'

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@lordgamez lordgamez requested a review from martinzink June 26, 2023 10:29
@lordgamez lordgamez marked this pull request as ready for review June 26, 2023 13:14
@lordgamez lordgamez changed the base branch from MINIFICPP-1719 to main July 17, 2023 13:25
controller/MiNiFiController.cpp Outdated Show resolved Hide resolved
controller/MiNiFiController.cpp Outdated Show resolved Hide resolved
libminifi/include/io/AsioStream.h Outdated Show resolved Hide resolved
libminifi/include/io/AsioStream.h Outdated Show resolved Hide resolved
libminifi/src/c2/ControllerSocketProtocol.cpp Outdated Show resolved Hide resolved
libminifi/src/c2/ControllerSocketProtocol.cpp Show resolved Hide resolved
libminifi/src/io/InputStream.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants