Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-2187 Free up disk space on CI runners for CentOS job #1632

Closed
wants to merge 1 commit into from

Conversation

lordgamez
Copy link
Contributor

To avoid running out of disk space on the centos build job, we can free up space according to these comments:
actions/runner-images#2840 (comment)
actions/runner-images#2606 (comment)

After checking the available disk space before and after removing these directories, I found that we can gain around additional 27GB of disk space with this change:

Filesystem      Size  Used Avail Use% Mounted on
/dev/root        84G   65G   19G  78% /
Filesystem      Size  Used Avail Use% Mounted on
/dev/root        84G   39G   46G  46% /

https://issues.apache.org/jira/browse/MINIFICPP-2187


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@lordgamez lordgamez marked this pull request as ready for review August 17, 2023 14:38
@martinzink
Copy link
Member

Didnt dwelve into this too much but maybe we could use an off the shelf solution from marketplace? https://github.com/marketplace/actions/free-disk-space-ubuntu

@lordgamez
Copy link
Contributor Author

Didnt dwelve into this too much but maybe we could use an off the shelf solution from marketplace? https://github.com/marketplace/actions/free-disk-space-ubuntu

Although it looks better, I think it's a bit simpler and more direct to delete these specific directories, also we don't have to request permission for a new action from Apache.

@fgerlits fgerlits closed this in b1c3720 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants