Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Makefile/Kconfig dependency checks #2106

Open
PetteriAimonen opened this issue Oct 5, 2023 · 0 comments
Open

Clean up Makefile/Kconfig dependency checks #2106

PetteriAimonen opened this issue Oct 5, 2023 · 0 comments

Comments

@PetteriAimonen
Copy link
Contributor

Some of the application Makefiles have configuration checks that overlap dependencies given in Kconfig and Make.defs.
Ideally each check should be done at only one place, and dependencies should be handled by Kconfig.

Note that enabling partial functionality based on config checks in Makefile is fine, but if the whole application depends on some configuration item, that should be a dependency in Kconfig.

Makefiles that have a duplicate check for CONFIG_appname in both Make.defs and Makefile:

  • fsutils/ipcfg
  • fsutils/mkfatfs
  • fsutils/mksmartfs
  • fsutils/passwd
  • netutils/dhcp6c
  • netutils/ping

Makefiles that check for some other config item such as CONFIG_NET_UDP. In most cases the dependency is already in Kconfig and the Makefile check can be removed, in other cases dependency should be added to Kconfig:

  • netutils/dhcpc
  • netutils/dhcpd
  • netutils/discover
  • netutils/ftpc
  • netutils/ftpd
  • netutils/ntpclient
  • netutils/smtp
  • netutils/telnetc
  • netutils/tftpc
  • netutils/thttpd
  • netutils/webclient
  • netutils/webserver
  • netutils/xmlrpc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant