Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch: cxd56xx: Fix cxd56xx for SMP #14842

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

masayuki2009
Copy link
Contributor

Summary

  • In sem: change sem wait to atomic operation #14465, atomic_compare_exchange_weak_explicit() was newly introduced in semaphore. However, cxd56xx has an issue with the API if SMP is enabled (see up_testset2 in cxd56_testset.c).
  • This commit fixes the issue by using LIBC_ARCH_ATOMIC.

Impact

  • Only cxd56xx SoCs in SMP mode.

Testing

  • Tested with spresense:smp, spresense:wifi_smp
  • NOTE: If DEBUG_ASSERTIONS is enabled assert would be happend. I think this might be another issue.

Summary:
- In apache#14465,
  atomic_compare_exchange_weak_explicit() was newly introduced
  in semaphore. However, cxd56xx has an issue with the API
  if SMP is enabled (see up_testset2 in cxd56_testset.c).
- This commit fixes the issue by using LIBC_ARCH_ATOMIC.

Impact:
- Only cxd56xx SoCs in SMP mode.

Testing:
- Tested with spresense:smp, spresense:wifi_smp
- NOTE: If DEBUG_ASSERTIONS is enabled assert would be happend.
  I think this might be another issue.

Signed-off-by: Masayuki Ishikawa <[email protected]>
@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture Size: XS The size of the change in this PR is very small labels Nov 19, 2024
@xiaoxiang781216 xiaoxiang781216 merged commit 1d6ece7 into apache:master Nov 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: arm Issues related to ARM (32-bit) architecture Size: XS The size of the change in this PR is very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants