Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/stm32: split nucleo-f4x1re into separate boards #14853

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

raiden00pl
Copy link
Contributor

@raiden00pl raiden00pl commented Nov 19, 2024

Summary

  • boards/stm32: split nucleo-f4x1re into separate boards
    Split nucleo-f4x1re into nucleo-f401re and nucleo-f411re. These are separate boards and should be in separate folders as it is done for all other nucleo boards in NuttX

  • boards/Kconfig: fix bad indent

Impact

Breaking change for nucleo-f4x1re users. There is no longer nucleo-f4x1re directory, user must use nucleo-f401re or nucleo-f411re.

Now all Nucleo boards supported by NuttX have their own separate directory.

Testing

local build with make and cmake

@raiden00pl raiden00pl added the breaking change This change requires a mitigation entry in the release notes. label Nov 19, 2024
@github-actions github-actions bot added Area: Documentation Improvements or additions to documentation Area: Tooling Area: CI Board: arm Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces. labels Nov 19, 2024
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@simbit18
Copy link
Contributor

@raiden00pl need to edit here

/arm/stm32/nucleo-f4x1re/configs/f411-nsh,CONFIG_ARM_TOOLCHAIN_GNU_EABI

Split nucleo-f4x1re into nucleo-f401re and nucleo-f411re.
These are separate boards and should be in separate directories as it's
done for all other nucleo boards in NuttX
fix bad indent in boards/Kconfig
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@raiden00pl
Copy link
Contributor Author

@simbit18 thank for the info. Fixed

@jerpelea jerpelea merged commit 79e220d into apache:master Nov 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CI Area: Documentation Improvements or additions to documentation Area: Tooling Board: arm breaking change This change requires a mitigation entry in the release notes. Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants