-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arm: remove up_set_current_regs/up_current_regs #14865
Open
hujun260
wants to merge
1
commit into
apache:master
Choose a base branch
from
hujun260:apache_18
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+275
−660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Arch: arm
Issues related to ARM (32-bit) architecture
Board: arm
Size: L
The size of the change in this PR is large
labels
Nov 20, 2024
[Experimental Bot, please feedback here] Yes, this PR appears to meet the basic NuttX requirements, although some sections could be more thoroughly filled out. Specifically:
Recommendation: Revise the PR description to address the missing information highlighted above. A more complete description will make it easier for reviewers to understand and approve the changes. |
pussuw
reviewed
Nov 20, 2024
pussuw
reviewed
Nov 20, 2024
pussuw
reviewed
Nov 20, 2024
pussuw
reviewed
Nov 20, 2024
hujun260
force-pushed
the
apache_18
branch
3 times, most recently
from
November 20, 2024 13:46
b317c40
to
8e07294
Compare
pussuw
reviewed
Nov 20, 2024
reason: up_set_current_regs initially had two functions: 1: To mark the entry into an interrupt state. 2: To record the context before an interrupt/exception. If we switch to a new task, we need to store the upcoming context regs by calling up_set_current_regs(regs). Currently, we record the context in other ways, so the second function is obsolete. Therefore, we need to rename up_set_current_regs to better reflect its actual meaning, which is solely to mark an interrupt. Signed-off-by: hujun5 <[email protected]>
pussuw
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Arch: arm
Issues related to ARM (32-bit) architecture
Board: arm
Size: L
The size of the change in this PR is large
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
remove up_set_current_regs/up_current_regs
reason:
up_set_current_regs initially had two functions:
1: To mark the entry into an interrupt state.
2: To record the context before an interrupt/exception. If we switch to
a new task, we need to store the upcoming context regs by calling up_set_current_regs(regs).
Currently, we record the context in other ways, so the second function is obsolete. Therefore, we need to rename up_set_current_regs to better reflect its actual meaning, which is solely to mark an interrupt.
Impact
arm arch
Testing
ostest
qemu
qemu-armv7a:smp
mps2-an500:nsh