Updated TLS to v1.2 for TimeStampSimpleHttpClient #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you making this change just because it looks wrong or because you have hit an issue? With POI, we work with real use cases because the Microsoft specs can be hard to interpret. |
|
the logic you are changing only appears to happens when ignoreHttpsCertificates = true - are you changing to this true (it defaults to false) Ideally you should not ignore the HTTPS certs |
To prevent incompatibility in the future, due to the deprecated state of the algo No current issues whatsoever, (very) low priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple update of chosen algo. ("TLS"); vs. ("TLSv1.2");