Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run mvn spotless:apply with pre-commit so that it runs on git commit #1643

Open
jbampton opened this issue Oct 15, 2024 · 1 comment
Open

Comments

@jbampton
Copy link
Member

As an extra check it would be good to add mvn spotless:apply to pre-commit so that it runs on git commit

Seems both Java and Scala are not listed as supported languages for pre-commit but they do have:

  • docker
  • docker_image
  • script
  • system

"System hooks provide a way to write hooks for system-level executables which don't have a supported language above (or have special environment requirements that don't allow them to run in isolation such as pylint).

This hook type will not be given a virtual environment to work with – if it needs additional dependencies the consumer must install them manually.

Support: the support of system hooks depend on the executables."

https://pre-commit.com/#supported-languages

I found some issues about pre-commit and spotless:

diffplug/spotless#623

diffplug/spotless#178

Copy link

Thank you for your interest in Apache Sedona! We appreciate you opening your first issue. Contributions like yours help make Apache Sedona better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant