From 2945920b3908f6dfa4b6bae3addd03df136725bb Mon Sep 17 00:00:00 2001
From: Bobby Wang <wbo4958@gmail.com>
Date: Fri, 24 Jan 2025 09:21:17 +0800
Subject: [PATCH] comments

---
 python/pyspark/ml/evaluation.py | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/python/pyspark/ml/evaluation.py b/python/pyspark/ml/evaluation.py
index 6673f7dab61db..568583eb08ecb 100644
--- a/python/pyspark/ml/evaluation.py
+++ b/python/pyspark/ml/evaluation.py
@@ -312,6 +312,7 @@ def setParams(
         return self._set(**kwargs)
 
     def isLargerBetter(self) -> bool:
+        """Override this function to make it run on connect"""
         return True
 
 
@@ -471,9 +472,8 @@ def setParams(
         return self._set(**kwargs)
 
     def isLargerBetter(self) -> bool:
-        if self.getMetricName() in ["r2", "var"]:
-            return True
-        return False
+        """Override this function to make it run on connect"""
+        return self.getMetricName() in ["r2", "var"]
 
 
 @inherit_doc
@@ -709,14 +709,13 @@ def setParams(
         return self._set(**kwargs)
 
     def isLargerBetter(self) -> bool:
-        if self.getMetricName() in [
+        """Override this function to make it run on connect"""
+        return not self.getMetricName() in [
             "weightedFalsePositiveRate",
             "falsePositiveRateByLabel",
             "logLoss",
             "hammingLoss",
-        ]:
-            return False
-        return True
+        ]
 
 
 @inherit_doc
@@ -862,9 +861,8 @@ def setParams(
         return self._set(**kwargs)
 
     def isLargerBetter(self) -> bool:
-        if self.getMetricName() == "hammingLoss":
-            return False
-        return True
+        """Override this function to make it run on connect"""
+        return self.getMetricName() != "hammingLoss"
 
 
 @inherit_doc
@@ -1026,6 +1024,7 @@ def setWeightCol(self, value: str) -> "ClusteringEvaluator":
         return self._set(weightCol=value)
 
     def isLargerBetter(self) -> bool:
+        """Override this function to make it run on connect"""
         return True
 
 
@@ -1165,6 +1164,7 @@ def setParams(
         return self._set(**kwargs)
 
     def isLargerBetter(self) -> bool:
+        """Override this function to make it run on connect"""
         return True