Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3388 adapter deletion does not clean up asset links #3390

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from
Open

3388 adapter deletion does not clean up asset links #3390

wants to merge 18 commits into from

Conversation

tenthe
Copy link
Contributor

@tenthe tenthe commented Dec 30, 2024 •
edited
Loading

Purpose

Remove asset links when resource is deleted:

  • Adapter
  • Data Lake Storage
  • Data Source
  • Data View
  • File
  • Pipeline

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@tenthe tenthe linked an issue Dec 30, 2024 that may be closed by this pull request
Adapter Deletion Does Not Clean Up Asset Links #3388
Open
@github-actions github-actions bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code ui Anything that affects the UI backend Everything that is related to the StreamPipes backend testing Relates to any kind of test (unit test, integration, or E2E test). labels Dec 30, 2024
tenthe added 14 commits December 30, 2024 21:26
@tenthe
fix(#3388): Remove asset links from adapters when deleted
8385f8d
@tenthe
Merge branch 'dev' into 3388-adapter-deletion-does-not-clean-up-asset…
fcecdb4 
…-links
@tenthe
fix(#3388): Update streampipes version in asset-model-management module
caeb7bc
@tenthe
fix(#3388): Update streampipes version in asset-model-management module
1a8d6a9
@tenthe
refactor(#3388): Pipelines are now removed from the asset links when …
a1d7eeb 
…they are deleted
@tenthe
refactor(#3388): Pipelines are now removed from the asset links when …
08e01fc 
…they are deleted
@tenthe
refactor(#3388): Extend test to check if measurement is removed from …
94a53dd 
…asset links
@tenthe
refactor(#3388): Add assertions to go back button
4760477
@tenthe
refactor(#3390): Remove asset links when deleting a measurement
9b13132
@tenthe
refactor(#3398): Add failing test for file assets
206d9ba
@tenthe
refactor(#3398): Extract method validateOneAssetWithNoAssetLinks
c8af16a
@tenthe
refactor(#3398): Remove asset links of files when deleted
e77de80
@tenthe
refactor(#3398): Add e2e test to validate data view is removed
b1d5e16
@tenthe
refactor(#3398): Remove asset links when dashboard is removed
17bd54c
@tenthe tenthe marked this pull request as ready for review January 7, 2025 10:29
@github-actions GitHub Actions
Copy link
Contributor

Hello there 👋

We noticed that it's been some time since activity occurred on your pull request 🤔. In order to keep things moving forward, we're marking this PR as stale and giving you 7 days to respond before it's automatically closed ⏰.

Please take a moment to review your pull request and make any necessary updates or changes 👨‍💻. If you need more time or have any questions, please don't hesitate to let us know 💬.

Thank you for your contributions to our project, and we look forward to hearing back from you soon 🙏.

@github-actions github-actions bot added the stale Marks pull requests that are classified as `stale` by our bot. label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend Everything that is related to the StreamPipes backend dependencies Pull requests that update a dependency file java Pull requests that update Java code stale Marks pull requests that are classified as `stale` by our bot. testing Relates to any kind of test (unit test, integration, or E2E test). ui Anything that affects the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapter Deletion Does Not Clean Up Asset Links
1 participant
@tenthe