From d85fdf4bf9afc0c6ebed48da4c2ddba01308693c Mon Sep 17 00:00:00 2001 From: "JUST.in DO IT" Date: Wed, 11 Sep 2024 16:30:34 -0700 Subject: [PATCH] fix: filters panel broken due to tabs scroll (#30180) (cherry picked from commit be0a0ced251a3b168b17a230759c5138603800a7) --- .../plugins/plugin-chart-echarts/src/utils/tooltip.ts | 2 ++ superset-frontend/src/GlobalStyles.tsx | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/utils/tooltip.ts b/superset-frontend/plugins/plugin-chart-echarts/src/utils/tooltip.ts index 7110cae6d5cdb..f9de7905703a2 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/utils/tooltip.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/utils/tooltip.ts @@ -25,6 +25,8 @@ export function getDefaultTooltip(refs: Refs) { return { appendToBody: true, borderColor: 'transparent', + // CSS hack applied on this class to resolve https://github.com/apache/superset/issues/30058 + className: 'echarts-tooltip', position: ( canvasMousePos: [number, number], params: CallbackDataParams, diff --git a/superset-frontend/src/GlobalStyles.tsx b/superset-frontend/src/GlobalStyles.tsx index bd882e39732b1..16712bf451bd3 100644 --- a/superset-frontend/src/GlobalStyles.tsx +++ b/superset-frontend/src/GlobalStyles.tsx @@ -34,6 +34,11 @@ export const GlobalStyles = () => ( th { font-weight: ${theme.typography.weights.bold}; } + // CSS hack to resolve the issue caused by the invisible echart tooltip on + // https://github.com/apache/superset/issues/30058 + .echarts-tooltip[style*='visibility: hidden'] { + display: none !important; + } // TODO: Remove when on Ant Design 5. // Check src/components/Modal for more info. .modal-functions-ok-button {