You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SVG icons which have Apache Licence comment and XML tag result in the icon getting broken.
Removing <?xml version="1.0" encoding="UTF-8"... from those SVGs fixes the issue.
The issue got introduced in #26857 for two SVGs (apache-pinot.svg and csv.svg), and there are others which are already broken since long (e.g. apache-hive.svg).
CSV and Apache Pinot SVGs are not getting rendered
Screenshots/recordings
Superset version
master / latest-dev
Python version
3.9
Node version
16
Browser
Chrome
Additional context
Search <?xml version="1.0" encoding="UTF-8" in the full repository and we will find many other SVG files which could get broken in future if comment (<!-- ... -->) is added to them, or which are already broken (e.g. apache-hive.svg)
Checklist
I have searched Superset docs and Slack and didn't find a solution to my problem.
I have searched the GitHub issue tracker and didn't find a similar bug report.
I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
The text was updated successfully, but these errors were encountered:
Bug description
SVG icons which have Apache Licence comment and XML tag result in the icon getting broken.
Removing
<?xml version="1.0" encoding="UTF-8"...
from those SVGs fixes the issue.The issue got introduced in #26857 for two SVGs (
apache-pinot.svg
andcsv.svg
), and there are others which are already broken since long (e.g.apache-hive.svg
).Even GitHub is not able to render those SVGs (https://github.com/apache/superset/pull/26857/files#diff-ea23e99cde474e10690a62f28be5e102bb78ed0cd1e39612e96f0f4f1d48d380)
How to reproduce the bug
Supported Databases
sectionCSV
andApache Pinot
SVGs are not getting renderedScreenshots/recordings
Superset version
master / latest-dev
Python version
3.9
Node version
16
Browser
Chrome
Additional context
Search
<?xml version="1.0" encoding="UTF-8"
in the full repository and we will find many other SVG files which could get broken in future if comment (<!-- ... -->
) is added to them, or which are already broken (e.g.apache-hive.svg
)Checklist
The text was updated successfully, but these errors were encountered: