Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hitting undo on a dashboard shows last edited dashboard #31344

Open
3 tasks
yousoph opened this issue Dec 9, 2024 · 6 comments · May be fixed by #31809
Open
3 tasks

Hitting undo on a dashboard shows last edited dashboard #31344

yousoph opened this issue Dec 9, 2024 · 6 comments · May be fixed by #31809
Assignees
@fardin-developer
Labels
dashboard:editmode Related to te Dashboard edit mode preset:bounty:bug Bugs that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached.

Comments

@yousoph
Copy link
Member

yousoph commented Dec 9, 2024

Bug description

Repro steps

  1. Go to a dashboard (A) and edit it and save
  2. Go to dashboard list
  3. Select another dashboard (B) and hit edit
  4. Click on the undo button

Actual results:
Undo will show dashboard A even though you are on dashboard B.
Making additional changes on the dashboard will allow the user to incorrectly save the changes.

Expected results:
Undo button shouldn't be enabled if there are no actions made yet on the second dashboard.
Undoing in one dashboard should never load a different dashboard

Screenshots/recordings

Screen.Recording.2024-09-13.at.4.23.54.PM.mov

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@dosubot dosubot bot added the dashboard:editmode Related to te Dashboard edit mode label Dec 9, 2024
@geido
Copy link
Member

geido commented Dec 23, 2024

🎉 Preset Bounty Available: $150 USD 🎉

To claim this bounty, please carefully follow the steps below.

📋 Steps to Participate

  1. Review Guidelines:
    Read through the Preset Bounty Program Contribution Guide for complete details on bounty requirements.

  2. Show Your Interest:
    Complete the Preset Bounty Program Survey and comment this issue to express your interest.

  3. Join the Slack Channel:
    After completing the survey, you’ll receive an invitation to the dedicated Apache Superset Slack channel.

  4. Get Assigned:
    To officially start, ensure a Bounty Program Manager has assigned you to this issue.

  5. Submit Your Solution:
    When ready, submit your solution with the Fixes #{issue_number} notation in your Pull Request description.

  6. Claim Your Bounty:
    Sign up at GitPay.me and submit your solution via: https://gitpay.me/#/task/1031

💡 Additional Notes

  • Only developers assigned by a Bounty Program Manager should start working on this issue to win the bounty.
  • Be sure to follow the guide closely to avoid any delays in payment. Please, allow a few days after your PR has been merged for the bounty to be released.

Good luck, and happy coding! 🎉

@geido geido added preset:bounty Issues that have been selected by Preset and have a bounty attached. preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. preset:bounty:bug Bugs that have been selected by Preset and have a bounty attached. and removed preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. labels Dec 23, 2024
@fardin-developer
Copy link
Contributor

Please assign me, I would love to work on this. --Thank you.

@FayadIdriss
Copy link

Hello :) i can work on this issue

@Niharika0104
Copy link

Can I work on this issue?

@Chetan774
Copy link

Could you please assign this issue to me ? I have worked on similar issue in my current project.

@syedbarimanjan
Copy link

@geido can you assign this issue to me as it has been 2 weeks since it was assigned and no work has been done towards resolving it by the assignee.

@fardin-developer fardin-developer linked a pull request Jan 12, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fardin-developer fardin-developer

Labels
dashboard:editmode Related to te Dashboard edit mode preset:bounty:bug Bugs that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Prevent undo functionality from referencing incorrect dashboard edits fardin-developer/superset
8 participants
@yousoph @geido @Chetan774 @fardin-developer @syedbarimanjan @Niharika0104 @FayadIdriss and others