Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added missing pod labels for init job #30956

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

glothriel
Copy link

SUMMARY

Added missing pod labels for init job. Without them it's impossible to dynamically set labels in environments with Network Policies engaged.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

skip

TESTING INSTRUCTIONS

Running helm template will suffice.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, LGTM. However, I noticed we're also missing the standard metadata.labels on this template that are found in the other ones (app, chart, release, heritage) - could you add those while we're at it?

@glothriel
Copy link
Author

@villebro Some pre-check (helm docs modified?) failed for the previous commit, should I perform some additional action?

@villebro
Copy link
Member

villebro commented Nov 19, 2024

@glothriel you need to run helm-docs to rebuild README.md, as it's missing init.podLabels (check pre-commit hooks, which does this automatically). Also, please bump the version to 0.13.3, as 0.13.2 was just released.

@villebro
Copy link
Member

@glothriel this PR requires yet another rebase, as we're now already on version 0.13.3. Also, note that the version was not updated in the README in the latest commits, so you may want to consider installing pre-commit to automatically sync the README when adding new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants