-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added missing pod labels for init job #30956
base: master
Are you sure you want to change the base?
fix: added missing pod labels for init job #30956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, LGTM. However, I noticed we're also missing the standard metadata.labels
on this template that are found in the other ones (app, chart, release, heritage) - could you add those while we're at it?
@villebro Some pre-check (helm docs modified?) failed for the previous commit, should I perform some additional action? |
@glothriel you need to run |
@glothriel this PR requires yet another rebase, as we're now already on version 0.13.3. Also, note that the version was not updated in the README in the latest commits, so you may want to consider installing |
SUMMARY
Added missing pod labels for init job. Without them it's impossible to dynamically set labels in environments with Network Policies engaged.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
skip
TESTING INSTRUCTIONS
Running helm template will suffice.
ADDITIONAL INFORMATION