Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPP] Inconsistent output files under win and unix #147

Open
761417898 opened this issue Jul 3, 2024 · 1 comment
Open

[CPP] Inconsistent output files under win and unix #147

761417898 opened this issue Jul 3, 2024 · 1 comment

Comments

@761417898
Copy link
Contributor

The contents of the generated files of the programs in example and benchmark are inconsistent between unix and win. In Windows, if we open a file without O_BINARY flags, the system will replace '\n' with '\r\n' when the file is written

@HTHou
Copy link
Contributor

HTHou commented Jul 3, 2024

Yes, it was an issue we met in IoTDB as well.

This PR of IoTDB fixed that problem. We may solve it in TsFile by the same way. https://github.com/apache/iotdb/pull/12706/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants