Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Build breaks with the latest dmlc revision #17116

Closed
yurivict opened this issue Jun 25, 2024 · 1 comment
Closed

[Bug] Build breaks with the latest dmlc revision #17116

yurivict opened this issue Jun 25, 2024 · 1 comment
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it status:stale PR is stale and not being acted on for a while type: bug

Comments

@yurivict
Copy link

In file included from /wrkdirs/usr/ports/misc/tvm/work/tvm-0.16.0/src/meta_schedule/database/database.cc:20:
In file included from /wrkdirs/usr/ports/misc/tvm/work/tvm-0.16.0/src/meta_schedule/database/../utils.h:52:
/wrkdirs/usr/ports/misc/tvm/work/tvm-0.16.0/src/meta_schedule/database/../../support/base64.h:232:8: error: virtual function 'Write' has a different return type ('void') than the function it overrides (which has return type 'size_t' (aka 'unsigned long'))
  void Write(const void* ptr, size_t size) final {
  ~~~~ ^
/usr/local/include/dmlc/io.h:45:18: note: overridden virtual function is here
  virtual size_t Write(const void* ptr, size_t size) = 0;
          ~~~~~~ ^
2 errors generated.
@yurivict yurivict added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: bug labels Jun 25, 2024
@leizil
Copy link

leizil commented Sep 24, 2024

you can change "void" to "size_t" and "return size" in changed function.

virtual void write(const void* ptr,size_t size)
{   ....}

size_t write(const void * ptr,size_t size)
{
....
return size;
}

I find these files needed fix:

  • src/runtime/file_utils.h
  • src/support/base64.h
  • src/runtime/rpc/rpc_point.cc(rpc_socket_impl.cc)
  • src/support/pipe.h

@tqchen tqchen added the status:stale PR is stale and not being acted on for a while label Feb 8, 2025
@tqchen tqchen closed this as completed Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it status:stale PR is stale and not being acted on for a while type: bug
Projects
None yet
Development

No branches or pull requests

3 participants