Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

span_getter argument #358

Open
aricohen93 opened this issue Jan 6, 2025 · 0 comments
Open

span_getter argument #358

aricohen93 opened this issue Jan 6, 2025 · 0 comments
Assignees

Comments

@aricohen93
Copy link
Collaborator

if on_ents_only:
assert span_getter is None or on_ents_only is True, (
"Cannot use both `span_getter` and `on_ents_only` as a span selection "
"argument."
)
assert isinstance(on_ents_only, (list, str, set, bool)), (
"The `on_ents_only` argument should be a "
"string, a bool, a list or a set of string"
)
span_getter = "ents" if on_ents_only is True else on_ents_only
else:
span_getter = "ents"

It's a little confusing the usage of span_getter and on_ents_only. Both are non optional arguments but
I have the impression that span_getter taks either the value "ents" or either the value of on_ents_only.

So, what is it supposed to do ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants