Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement real time validation #133

Open
Siegrift opened this issue Jun 21, 2021 · 3 comments
Open

Implement real time validation #133

Siegrift opened this issue Jun 21, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers low priority Can wait until more pressing issues are resolved

Comments

@Siegrift
Copy link
Collaborator

As discussed in https://api3workspace.slack.com/archives/C020RCCC3EJ/p1624207461017900

The validation is triggered when the form is submitted (action is pressed), but we should probably validate real time for better UX. Sometimes it is easy to do, but sometimes not (I think we do some async validation as well).
@Siegrift Siegrift added enhancement New feature or request good first issue Good for newcomers low priority Can wait until more pressing issues are resolved labels Jun 21, 2021
@Siegrift Siegrift changed the title Implement real time validattion Implement real time validation Jun 21, 2021
@Siegrift
Copy link
Collaborator Author

Siegrift commented Jul 2, 2021

Another stretch to this validation is the following case:

  1. Open delegation modal (assuming you are able to delegate)
  2. You type the address and (possibly realtime) validation passes
  3. The address delegates in the meantime and you press a button
  4. The transaction would revert (because the address already has a delegate)...

Similar cases can happen for other things, the point is, that we should check whether the action is possible before crating the transaction, because blockchain state can change in the meantime...

However, this will happen very rarely.

@api3dao api3dao deleted a comment from ef3n9r98 Dec 6, 2022
@api3dao api3dao deleted a comment from ef3n9r98 Dec 6, 2022
@bbenligiray
Copy link
Member

Promoting products and services in issues is not welcome

@bbenligiray
Copy link
Member

I'm not sure that this is typical or needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers low priority Can wait until more pressing issues are resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbenligiray @Siegrift