-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement timestamp post-processing #27
Comments
@dcroote for visibility |
The alternative way of doing this is piggybacking on |
An alternative would be to create
|
I don't see how this is an improvement
It would be nice to have a Node (restricted) environment in the future once that stuff is more fleshed out so I'm not a fan of removing that field. I'm fine with forcing |
To me the array version feels like an unnecessary complexity. Both user has to think about why the specification is an array and we need to handle chaining the values through multiple processing snippets. |
We ended up never using it (says something for modular design imo) but considering that it's already there and working, I don't see the reason to remove it |
I think you misunderstood this:
I mean to create a new field which implements couple of improvements + delivers this new feature. We would still support the "legacy" post-processing though. We would ensure that only one of |
For reference I had agreed with |
As a note, this requires docs changes as well. |
I've updated a bunch of PRs (links in the editted issue description). |
Will ChainAPI use this change too? |
All PRs have been implemented and all except Airnode (which is to be released) are released. |
Currently, Airnode uses the API call time as the
timestamp
of the signed data. This doesn't cover two use cases:timestamp
to be the most recent block timestamp. (This is what Nodary does for LSD feeds at the moment.)timestamp
to be that.As a solution, I'm proposing a
timestampPostProcessingSpecifications
field at the same level aspostProcessingSpecifications
. This works exactly likepostProcessingSpecifications
, exceptoutput
of that will be used astimestamp
(rather thandata
).This obviously requires a change in the OIS format. The field can be optional similar to
postProcessingSpecifications
, which makes this a non-breaking change.EDIT: This requires changes in multiple projects.
The text was updated successfully, but these errors were encountered: