Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make less strict ESLint config for testing files #14

Open
Siegrift opened this issue Nov 15, 2023 · 2 comments
Open

Make less strict ESLint config for testing files #14

Siegrift opened this issue Nov 15, 2023 · 2 comments

Comments

@Siegrift
Copy link
Collaborator

Testing requires creating mocks and using fixtures and sometimes uglier mutable code. This is fine (and sometimes preferred) for tests, but with our strict production ESLint configuration we need to use multiple eslint disable comments which is ugly.

We could turn off the problematic rules in the test config (only applied for tests files based on filename pattern).

@Siegrift Siegrift changed the title Make less strict config for testing files Make less strict ESLint config for testing files Feb 27, 2024
@dcroote
Copy link
Collaborator

dcroote commented Jun 28, 2024

Close now that the eslint plugin has moved?

@Siegrift
Copy link
Collaborator Author

I'd transfer instead. That said, this is not necessarily the priority.

@Siegrift Siegrift transferred this issue from api3dao/commons Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants