Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with large enough trees #25

Open
bbenligiray opened this issue Jun 30, 2023 · 2 comments
Open

Doesn't work with large enough trees #25

bbenligiray opened this issue Jun 30, 2023 · 2 comments

Comments

@bbenligiray
Copy link
Member

The fundings are done through a multicall, and enough multicalls will exceed the block size and stall operation. At what tree size this becomes a problem is chain-specific (though anything below 100 recipients should always work). If the bot was able to batch multicalls in smaller sizes, this wouldn't be a problem. To avoid unnecessary complexity, I'd say let's wait and see what the actual user needs are.

@bbenligiray
Copy link
Member Author

Note that this suffers from a similar issue as in #27 because the static multicalls will also need to be batched, which means they will be done in separate block numbers. The potential solutions are again the same, either don't care about the maximum tree size (probably have MAXIMUM_TREE_SIZE=200 hardcoded in this repo that is validated wherever possible) or serve different batches of the same tree using different mnemonics (which sounds much worse than serving different depositories with different mnemonics).

@bbenligiray
Copy link
Member Author

This also applies here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants