Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix environment variable naming for RPC URLs #96

Closed
wants to merge 1 commit into from
Closed

Fix environment variable naming for RPC URLs #96

wants to merge 1 commit into from

Conversation

bdrhn9
Copy link

@bdrhn9 bdrhn9 commented Oct 9, 2023

Closes #95

@bdrhn9 bdrhn9 requested a review from acenolaza October 9, 2023 13:03
@bbenligiray
Copy link
Member

Wouldn't it make more sense to remove the _1?

@bdrhn9
Copy link
Author

bdrhn9 commented Oct 11, 2023

Wouldn't it make more sense to remove the _1?

If we aren't planing to use multiple RPCs, it makes sense more, yes.

@bbenligiray
Copy link
Member

The current _1 additions don't make it any easier to use multiple RPCs

@bdrhn9
Copy link
Author

bdrhn9 commented Oct 11, 2023

The current _1 additions don't make it any easier to use multiple RPCs

You're right. So fixing here is what you'd prefer?

@bbenligiray
Copy link
Member

Yeah

@acenolaza
Copy link
Collaborator

Closing PR due to being fixed here

@acenolaza acenolaza closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acenolaza acenolaza Awaiting requested review from acenolaza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make naming consistent with the config generator in manager-multisig while generating example.env file
3 participants
@bdrhn9 @bbenligiray @acenolaza