Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the deviation threshold be specified in percentage #14

Open
bbenligiray opened this issue Aug 1, 2023 · 0 comments
Open

Have the deviation threshold be specified in percentage #14

bbenligiray opened this issue Aug 1, 2023 · 0 comments
Assignees
Labels
Nodary To be present on the project Nodary API board

Comments

@bbenligiray
Copy link
Member

bbenligiray commented Aug 1, 2023

Currently, computeSponsorWalletAddress() expects deviationThreshold to be specified in "normalized percentages". For example, if the user wants to get the sponsor wallet address for 0.5% deviation threshold, they need to set deviationThreshold to be 0.5 * 1e6 = 500000 (https://github.com/nodaryio/examples/blob/main/scripts/get-sponsor-wallet-addresses.js#L16). The normalization method is an implementation detail that shouldn't be exposed to the user, the user should just call the function with 0.5.

This requires a major release, and https://github.com/nodaryio/examples and the manager-multisig will also need to be updated

@PrenaamD PrenaamD added the Nodary To be present on the project Nodary API board label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nodary To be present on the project Nodary API board
Projects
None yet
Development

No branches or pull requests

3 participants