Implement Airnode whitelisting #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
commented
Oct 30, 2023
metobom
reviewed
Oct 30, 2023
There was a problem hiding this comment.
I think it is better to use all instead of an empty array.
I am not sure whether not to add .nonempty to disallow [] since it doesn't make sense to deny all Airnodes.
I think empty arrays should be disallowed.
The "allowedAirnodes" configuration is used for both inserting/querying the data.
I couldn't catch the "querying" part, can you explain it?
I mean that an API call to get data for an non-whitelistested Airnode address with return 403. |
andreogle
approved these changes
Oct 30, 2023
Siegrift
force-pushed
the
log-heartbeat
branch
from
1a92b46 to
6397183
Compare
Siegrift
force-pushed
the
whitelist-airnodes
branch
from
8505777 to
a4fd602
Compare
Siegrift
force-pushed
the
whitelist-airnodes
branch
from
7f2bb6f to
77b7a99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98
Rationale
Adding the configuration option for whitelisting addresses is simple, but there is a special case - how to whitelist all? We can have a special meaning for empty array, similarly how it's done in Airnode but I think it would be better for this to be explicit and set it to
"all"instead (string literal instead of an array). Alternatively, we can drop the "whitelist all" use case.The naming is
"allowedAirnodes", because it's about Airnode addresses, but the service is not Airnode but Pusher. I don't mind this, because Pusher and Airnode are related.The
"allowedAirnodes"configuration is used for both inserting/querying the data. The "list airnode addresses" endpoint is unchanged, because when all Airnodes are allowed we would need to scan the data storage anyway.