Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stagger pusher #105

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Stagger pusher #105

merged 5 commits into from
Nov 7, 2023

Conversation

Siegrift
Copy link
Collaborator

@Siegrift Siegrift commented Oct 31, 2023 •
edited
Loading

Closes #50 (if this is the implementation we want to go with).

I pushed a docker image on my personal account with this change so it can be tested on AWS https://hub.docker.com/layers/siegrift/api3-pusher-testonly-clone/wip-stagger/images/sha256-45ec5db658f5f1e268ecbb9e1a693d6823b415a49272b49064d9647d5408586c?context=explore

@Siegrift Siegrift self-assigned this Oct 31, 2023
@Siegrift Siegrift requested a review from metobom October 31, 2023 17:00
metobom
metobom approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@metobom metobom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this with the Docker image @Siegrift published on his personal accounts.

There are no more timeouts on low cloud resources, it works smoothly.

@Siegrift
Copy link
Collaborator Author

Siegrift commented Nov 2, 2023 •
edited
Loading

There are no more timeouts on low cloud resources, it works smoothly.

Thanks. Do you have access to these graphs ? I'd be interested if the memory and CPU consumption changed somehow.

Btw. I will wait with merging until we agree that this is the implementation we want to go with (cc: @bbenligiray).

@metobom
Copy link
Member

metobom commented Nov 2, 2023

@Siegrift
newplot

@Siegrift
Copy link
Collaborator Author

Siegrift commented Nov 2, 2023

Thanks, I see that the memory usage dropped significantly (by ~50%) which I don't have explanation for 🤔

@Siegrift Siegrift changed the title WIP: Stagger pusher Stagger pusher Nov 7, 2023
@Siegrift Siegrift merged commit 0bad6fc into main Nov 7, 2023
4 checks passed
@Siegrift Siegrift deleted the pusher-stagger branch November 7, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbenligiray bbenligiray bbenligiray left review comments

@metobom metobom metobom approved these changes

Assignees

@Siegrift Siegrift

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-stagger signed API updates to throttle API calls optimally
3 participants
@Siegrift @metobom @bbenligiray