Run as non-root users #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
approved these changes
Nov 21, 2023
Siegrift
reviewed
Nov 21, 2023
Dockerfile
Outdated
| @@ -34,20 +34,40 @@ RUN pnpm run --recursive build | |||
|
|
|||
| # Create a separate stage for pusher package. We create a temporary stage for deployment and then copy the result into | |||
| # the final stage. Only the production dependencies and package implementation is part of this last stage. | |||
| ENV name="deployed-pusher" | |||
There was a problem hiding this comment.
Do we use the ENV (and the similar one below) somewhere?
There was a problem hiding this comment.
ah, no, I'll remove it. I tried to use this ENV originally to reduce duplication/single source of truth but Dockerfiles seemingly can't work this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #117
As per the linked issue this PR adds largely a copy of the process used in the airseeker-v2 Dockerfile to make the "app" run as a non-privileged user.
I tried to use variable substitution to reduce the duplication but Dockerfiles are seemingly very limited in that area.