Fix delayed queue premature data prune, add tests #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
force-pushed
the
unit-test-delayed-queue
branch
from
52b7032 to
0110de2
Compare
Siegrift
force-pushed
the
resolve-todos
branch
from
5c53161 to
9ef0294
Compare
Siegrift
force-pushed
the
unit-test-delayed-queue
branch
from
0110de2 to
c1036d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43
While I was working on these tests I realized that the delayed queue should not purge the data during the
getcall. The implementation assumed that one queue will be called with just a singleupdateTime, but that may not be true because there can be multiple triggers (with differentupdateTimes).The new implementation made
getfunction pure and created a newprunefunction which can be called to remove the data that is no longer necessary. The queue is first initialized with amaximumUpdateTimewhich is the maximum update time across all triggers.