Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent naming #62

Merged
merged 1 commit into from
Oct 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ A monorepo for managing signed data. Consists of:

- [api](./packages/api/README.md) - A service for storing and accessing signed data. It provides endpoints to handle
signed data for a specific airnode.
- [data-pusher](./packages/data-pusher/README.md) - A service for pushing data provider signed data.
- [common](./packages/common/README.md) - An internal-only package with common types and utilities used by other
packages.
- [pusher](./packages/pusher/README.md) - A service for pushing data provider signed data.

## Getting started

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
6 changes: 2 additions & 4 deletions packages/data-pusher/README.md → packages/pusher/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
<!-- TODO: Rename data-pusher workspace to pusher -->

# data-pusher
# pusher

> A service for storing and accessing signed data.

Expand Down Expand Up @@ -350,7 +348,7 @@ pnpm run docker:stop

### Development only docker instructions

By default the `CONFIG_PATH` is points to the `data-pusher/config` directory. This means it's possible to run:
By default the `CONFIG_PATH` is points to the `pusher/config` directory. This means it's possible to run:

```bash
pnpm run docker:build
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,19 @@ WORKDIR /usr/src/app
# the monorepo into the image.
COPY . .
RUN npm install -g pnpm
# Installs all dependencies only for the data-pusher package.
RUN pnpm install --recursive --filter data-pusher
# Builds the data-pusher package.
RUN pnpm run --filter data-pusher build
# Installs all dependencies only for the pusher package.
RUN pnpm install --recursive --filter pusher
# Builds the pusher package.
RUN pnpm run --filter pusher build

# Step 2: Run the built application.
FROM node:18-alpine

WORKDIR /usr/src/app/packages/data-pusher
WORKDIR /usr/src/app/packages/pusher
# Copies the built application from the builder image.
COPY --from=builder /usr/src/app/packages/data-pusher/dist ./dist
COPY --from=builder /usr/src/app/packages/pusher/dist ./dist
# Copies the package.json from the builder image.
COPY --from=builder /usr/src/app/packages/data-pusher/package.json .
COPY --from=builder /usr/src/app/packages/pusher/package.json .
# This Dockerfile copies the pnpm-lock.yaml file from the monorepo root to install locked dependency versions. This
# guarantees consistency by utilizing identical sets of dependencies.
COPY pnpm-lock.yaml .
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
version: '3.8'

services:
data-pusher:
pusher:
build:
context: ../../../
dockerfile: ./packages/data-pusher/docker/Dockerfile
dockerfile: ./packages/pusher/docker/Dockerfile
environment:
- NODE_ENV=production
volumes:
Expand All @@ -18,4 +18,4 @@ services:
# Docker Compose doesn't allow setting default values based on the current shell's environment, so we can't access
# current working directory and default to "$(pwd)/config". For this reason we default to the config folder
# relative to the docker-compose.yml file.
- ${CONFIG_PATH:-../config}:/usr/src/app/packages/data-pusher/dist/config
- ${CONFIG_PATH:-../config}:/usr/src/app/packages/pusher/dist/config
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "data-pusher",
"name": "pusher",
"version": "1.0.0",
"engines": {
"node": "^18.14.0",
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.