Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace page_options with context_options for PlaywrightBrowserPlugin #755

Closed
Mantisus opened this issue Nov 27, 2024 · 0 comments · Fixed by #796
Closed

Replace page_options with context_options for PlaywrightBrowserPlugin #755

Mantisus opened this issue Nov 27, 2024 · 0 comments · Fixed by #796
Assignees
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@Mantisus
Copy link
Collaborator

The page_options parameter worked when pages were created without using context:
https://playwright.dev/python/docs/api/class-browser#browser-new-page

Currently, we are working with context created in PlaywrightBrowserController. When creating a page from context, it doesn't accept any parameters:
https://playwright.dev/python/docs/api/class-browsercontext#browser-context-new-page

These parameters should now be passed when creating the context and therefore be renamed to context_options:
https://playwright.dev/python/docs/api/class-browser#browser-new-context

@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 27, 2024
@vdusek vdusek added the bug Something isn't working. label Nov 28, 2024
@Mantisus Mantisus self-assigned this Dec 9, 2024
@vdusek vdusek added this to the 104th sprint - Tooling team milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants