Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider dropping getSample in 3.0 #219

Open
wickedest opened this issue Feb 9, 2020 · 1 comment
Open

Consider dropping getSample in 3.0 #219

wickedest opened this issue Feb 9, 2020 · 1 comment

Comments

@wickedest
Copy link

I was investigating why sway is 10.4 MB. A good chunk of that size is related to json-schema-faker and its dependencies (4.2 MB). Digging into the code, it only seems to be used by getSample. Is this feature really necessary? I mean, getExample can provide much better samples.
@whitlockjc
Copy link
Member

The current refactoring to support 3.x will not have json-schema-faker, it's too bulky and not as easy to slim down as we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitlockjc @wickedest