Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements for query parameters for 2x #320

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Enhancements for query parameters for 2x #320

merged 1 commit into from
Oct 18, 2023

Conversation

kedarkhaire
Copy link
Collaborator

Fixes #311

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #320 (eb257de) into 2.x (9b6138e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #320   +/-   ##
=========================================
  Coverage     87.55%   87.55%           
  Complexity     1727     1727           
=========================================
  Files           349      349           
  Lines          4613     4613           
=========================================
  Hits           4039     4039           
  Misses          574      574
Flag Coverage Δ
unittests 87.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ntroller/PaginatedEntityListingControllerTrait.php 100.00% <100.00%> (ø)

@kedarkhaire kedarkhaire added this to the 2.1.2 milestone Oct 18, 2023
@kedarkhaire kedarkhaire added the enhancement New feature or request label Oct 18, 2023
@shishir-intelli shishir-intelli changed the title Enhancements for query parameters Enhancements for query parameters for 2x Oct 18, 2023
shishir-intelli
shishir-intelli approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kedarkhaire kedarkhaire merged commit 02e38dc into apigee:2.x Oct 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shishir-intelli shishir-intelli shishir-intelli approved these changes

@divya-intelli divya-intelli Awaiting requested review from divya-intelli

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@kedarkhaire @shishir-intelli