Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MethodSignatureMismatch: Method supportsDenormalization with return type '' is different to return type 'bool' of inherited method #386

Closed
wants to merge 3 commits into from
Closed

MethodSignatureMismatch: Method supportsDenormalization with return type '' is different to return type 'bool' of inherited method #386

wants to merge 3 commits into from

Conversation

kedarkhaire
Copy link
Collaborator

Fixes #383

@kedarkhaire
MethodSignatureMismatch: Method supportsDenormalization with return t…
470ba76 
…ype '' is different to return type 'bool' of inherited method
@kedarkhaire kedarkhaire added this to the 3.0.8 milestone Oct 15, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.68%. Comparing base (f43f83e) to head (c14b1b8).
Report is 3 commits behind head on 4.x.

Files with missing lines Patch % Lines
src/Serializer/EntitySerializer.php 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                4.x     #386      +/-   ##
============================================
- Coverage     86.81%   86.68%   -0.14%     
+ Complexity     1768     1737      -31     
============================================
  Files           349      343       -6     
  Lines          4643     4220     -423     
============================================
- Hits           4031     3658     -373     
+ Misses          612      562      -50
Flag Coverage Δ
unittests 86.68% <97.87%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...geeX/Denormalizer/AcceptedRatePlanDenormalizer.php 85.71% <100.00%> (ø)
...pi/ApigeeX/Denormalizer/ApiProductDenormalizer.php 100.00% <100.00%> (ø)
src/Api/ApigeeX/Denormalizer/AppDenormalizer.php 70.00% <100.00%> (-3.34%) ⬇️
...eX/Denormalizer/AppGroupMembershipDenormalizer.php 93.33% <100.00%> (ø)
...i/ApigeeX/Denormalizer/BillingTypeDenormalizer.php 85.71% <100.00%> (ø)
...rmalizer/DeveloperAcceptedRatePlanDenormalizer.php 83.33% <100.00%> (ø)
.../Denormalizer/DeveloperBillingTypeDenormalizer.php 83.33% <100.00%> (ø)
...pigeeX/Denormalizer/PrepaidBalanceDenormalizer.php 85.71% <100.00%> (ø)
.../Api/ApigeeX/Denormalizer/RatePlanDenormalizer.php 90.00% <100.00%> (ø)
...igeeX/Denormalizer/RatePlanDenormalizerFactory.php 100.00% <100.00%> (ø)
... and 37 more

... and 102 files with indirect coverage changes

@kedarkhaire kedarkhaire modified the milestones: 3.0.8, 4.0.0 Oct 16, 2024
@kedarkhaire kedarkhaire mentioned this pull request Oct 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giteshk giteshk Awaiting requested review from giteshk

@shishir-intelli shishir-intelli Awaiting requested review from shishir-intelli

@divya-intelli divya-intelli Awaiting requested review from divya-intelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@kedarkhaire