-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add magic get/setters for entityreferences (#948) #956
base: 3.x
Are you sure you want to change the base?
Conversation
Thank you @boobaa for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, we are one step closer.
These are my first impressions, I'd not call it a review.
This PR definitely needs extensive manual testing for a start and examining what is actually stored in an object and how these methods behave, e.g.: whether attributes are supported or not by this change, etc.
After this looks like a working solution, automated test coverage would be also a must (IMO).
Also had to distinguish apigee baseFields: without doing that, |
Hi @boobaa We cannot merge this as it does not solves the mentioned issue. It will need more further work and testing. Thanks! |
Hi @boobaa
This led to the failure of manual test from my end. Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #956 +/- ##
=========================================
Coverage 44.20% 44.20%
Complexity 3029 3029
=========================================
Files 341 341
Lines 11086 11086
=========================================
Hits 4901 4901
Misses 6185 6185
|
Here's what I did for reproduction:
Expected result: team getting saved properly, with the new field being displayed with the selected API (product). Actual result without the patch: WSOD (
Actual result with the patch: team got saved properly, with the new field displaying the selected API (product). FTR, I ran
Hope this helps. |
Hi @boobaa Drupal version - 10.1.8 & 10.2.2
The steps which you mentioned, in that case, we do not see any error/WSOD on the page without applying any patch. Issue occurs when the above 2 points are performed. Thanks! |
Hi @kedarkhaire , as the customer does not want to litter their Apigee Edge with random API products when teams are getting created/edited, but only allow users to select from already-existing API products, those options are NOT enabled. |
Closes #948.