Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal core patch changes Entity API #964

Closed
lekob opened this issue Oct 26, 2023 · 4 comments · Fixed by #965
Closed

Drupal core patch changes Entity API #964

lekob opened this issue Oct 26, 2023 · 4 comments · Fixed by #965
Labels
bug Something isn't working

Comments

@lekob
Copy link

lekob commented Oct 26, 2023

Description

The patch added in #931 adds two methods to EntityInterface (getOriginal and setOriginal). Classes that implement EntityInterface will need to implement these two methods or be declared as abstract.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Make sure that in your project's root composer.json extra.enable-patching is set to true.
  2. Require drupal/apigee_edge 3.0.2.
  3. Make sure that the "Add a method to access the original property" patch is applied to Drupal core.
  4. Require and enable an extension that has a class that implements EntityInterface (example: drupal/simple_oauth).
  5. Configure and use the other extension as described in its documentation.

Actual Behavior

PHP Fatal error.

Expected Behavior

Updating to drupal/apigee_edge 3.0.2 should not cause other extensions to fail.

Version Info

3.0.2

@lekob lekob added the bug Something isn't working label Oct 26, 2023
mxr576 added a commit to mxr576/apigee-edge-drupal that referenced this issue Oct 26, 2023
@divya-intelli
Copy link
Collaborator

@lekob , Thank you for notifying us.
The patch was added for deprecations notice.
We will be soon releasing apigee_edge. The patch will be removed with PR #965.

@mxr576
Copy link
Contributor

mxr576 commented Oct 27, 2023

@divya-intelli Thanks for the quick reply. A 3.0.3 release today would be much appropriated because we have just realized that 3.0.1 release was broken because it called a private constructor of \League\Period\Period that was fixed in 3.0.2: 746eb5d

So we are kinda in a situation where there is no acceptable release of Apigee Edge 3.x for D10 ;S Maybe 3.0.0... I have to double check that

@divya-intelli
Copy link
Collaborator

@mxr576 ,

  1. For edge version 3.0.1 it is picking apigee client 3.0.2 as we have used ^ instead of ~ for apigee client in composer. Going forward for any deprecations/library updates we will be using ~ for new releases.
  2. We have scheduled the release of edge version 3.0.3 on Monday.

@divya-intelli
Copy link
Collaborator

@lekob @mxr576 , we have released edge version 3.0.3 , this release includes PR #965.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants