Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps keys create and update not setting expiration on key #341

Closed
kurtkanaskie opened this issue Dec 1, 2023 · 1 comment · Fixed by #343
Closed

apps keys create and update not setting expiration on key #341

kurtkanaskie opened this issue Dec 1, 2023 · 1 comment · Fixed by #343

Comments

@kurtkanaskie
Copy link
Collaborator

Both "apps keys create" and "apps keys update" have an --expires option, but it doesn't set the expiration on the key, it's always -1.

I think this is an API limitation, as I've not been able to find the API to do this.
srinandan added a commit that referenced this issue Dec 2, 2023
@srinandan
bug: fixes missing expiry during update #341
c88639f
@srinandan srinandan linked a pull request Dec 2, 2023 that will close this issue
bug: fixes missing expiry during update #341 #343
Merged
@kurtkanaskie
Copy link
Collaborator Author

Actually, this is supported using expiresInSeconds property, but cannot setting expiresAt is not supported.

srinandan added a commit that referenced this issue Dec 14, 2023
@srinandan @kurtkanaskie
bug: fixes missing expiry during update #341 (#343)
4ab7176 
* bug: fixes missing expiry during update #341

* expires in seconds consistently and for keys create and apps genkey only

* Setting expires consistently for seconds or Apps and AppGroup Apps

* minor linting fix

* Properly reset client response setting

---------

Co-authored-by: Kurt Kanaskie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug: fixes missing expiry during update #341 apigee/apigeecli
1 participant
@kurtkanaskie