Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break up TD004 into multiple plugins #459

Closed
DinoChiesa opened this issue Aug 23, 2024 · 1 comment
Closed

break up TD004 into multiple plugins #459

DinoChiesa opened this issue Aug 23, 2024 · 1 comment

Comments

@DinoChiesa
Copy link
Collaborator

DinoChiesa commented Aug 23, 2024

TD004 does a bunch of hygiene checks for HTTPTargetConnection. We need to separate out some of the function into new, separate plugins.

Now that we have the <!-- apigeelint disable XXXXX --> directive, people might want to disable some of the checks currently done by TD004, like the SSLInfo related things, but not others, like duplicate URL elements. Separating these checks into smaller related bunches , each contained in a new plugin, will allow better control.

Refactoring TD004 may cause a back-compatibility issue for anyone who is currently disabling TD004. After we introduce one or more additional plugins, they'll get warnings again. This should be a minor issue though, comparable to any case in which we introduce a new builtin plugin.

@DinoChiesa
Copy link
Collaborator Author

addressed in #478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant