Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new plugin: for Quota policy, if CountOnly found, should also have EnforceOnly #475

Open
DinoChiesa opened this issue Sep 27, 2024 · 2 comments

Comments

@DinoChiesa
Copy link
Collaborator

It should be the case that if there is an EnforceOnly Quota policy, we should also have a CountOnly policy attached.

@ssvaidyanathan @kurtkanaskie WDYT? Are there cases where it makes sense to violate this? For example, a CountOnly policy in a FlowHook-attached sharedflow, and an EnforceOnly policy directly attached in the proxy?

@kurtkanaskie
Copy link
Contributor

I've always used them in pairs. EnforceOnly doesn't increment the count so it's not useful on its own.
I suppose they could be in different shared flows (e.g. PreFlow flow hook and PostFlow flow hook).

@ssvaidyanathan
Copy link
Collaborator

I've always used them in pairs. EnforceOnly doesn't increment the count so it's not useful on its own. I suppose they could be in different shared flows (e.g. PreFlow flow hook and PostFlow flow hook).

Yes - thats how its been used, if they want it in two different sharedflows. Sometimes in request vs response flows as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants