Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect attributes in generated meta tags #1

Closed
apjanke opened this issue Dec 22, 2018 · 1 comment
Closed

Incorrect attributes in generated meta tags #1

apjanke opened this issue Dec 22, 2018 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@apjanke
Copy link
Owner

apjanke commented Dec 22, 2018

In the HTML output, there are a couple meta tags being generated by Ronn.

  <meta http-equiv='content-type' value='text/html;charset=utf8'>
  <meta name='generator' value='Ronn/v0.7.3 (http://github.com/rtomayko/ronn/tree/0.7.3)'>

I think these are invalid. The meta element doesn't take a name attribute; it takes a content attribute instead. These should be:

  <meta http-equiv='content-type' content='text/html;charset=utf8'>
  <meta name='generator' content='Ronn/v0.7.3 (http://github.com/rtomayko/ronn/tree/0.7.3)'>

Copied from rtomayko/ronn#106

@apjanke apjanke added the bug Something isn't working label Dec 22, 2018
@apjanke apjanke self-assigned this Dec 22, 2018
@apjanke
Copy link
Owner Author

apjanke commented Dec 22, 2018

Fixed in d645829

@apjanke apjanke closed this as completed Dec 22, 2018
@apjanke apjanke added this to the 0.7.4 milestone Dec 22, 2018
@apjanke apjanke added this to ronn-ng Jan 4, 2024
@apjanke apjanke moved this to Closed in ronn-ng Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

1 participant