-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor useQuery
tests to use toEqualQueryResult
- Part 1
#12273
Conversation
|
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 140cd8b870bff27818275f29 |
commit: |
}); | ||
|
||
// TODO: Refactor this test. This test does not test the thing it says it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My plan is to leave as many of these TODO comments in these series of PRs as I discover things, then come back in a separate PR to do them. Please take a look at anything with a TODO
comment and let me know if you disagree.
useQuery
tests to use toEqualQueryResult
part 1useQuery
tests to use toEqualQueryResult
- Part 1
…ith note about refactoring
…d case for rerendering
5a9a280
to
955d0af
Compare
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
Similar to #12260, this refactors
useQuery
tests to use the newtoEqualQueryResult
matcher. There are many tests in this suite, so this is the first of a series of PRs to make PR review a bit more digestable.