Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphql-ws peer dependecy #12278

Closed
ruizmarc opened this issue Jan 16, 2025 · 3 comments · Fixed by #12342
Closed

Update graphql-ws peer dependecy #12278

ruizmarc opened this issue Jan 16, 2025 · 3 comments · Fixed by #12342

Comments

@ruizmarc
Copy link

ruizmarc commented Jan 16, 2025

Issue Description

Hello,

Graphql-ws 6 has been released but peerDependecy for apollo-client has not been updated yet so npm crashes if using the new graphql-ws version:

2025-01-16T17:46:04.802Z frontend: #10 1.782 npm error While resolving: @apollo/[email protected]
2025-01-16T17:46:04.802Z frontend: #10 1.782 npm error Found: [email protected]
2025-01-16T17:46:04.802Z frontend: #10 1.782 npm error node_modules/graphql-ws
2025-01-16T17:46:04.802Z frontend: #10 1.782 npm error   graphql-ws@"^6.0.0" from the root project
2025-01-16T17:46:04.802Z frontend: #10 1.782 npm error
2025-01-16T17:46:04.802Z frontend: #10 1.782 npm error Could not resolve dependency:
2025-01-16T17:46:04.802Z frontend: #10 1.782 npm error peerOptional graphql-ws@"^5.5.5" from @apollo/[email protected]
2025-01-16T17:46:04.802Z frontend: #10 1.782 npm error node_modules/@apollo/client

Link to Reproduction

no required

Reproduction Steps

Update graphql-ws to 6.0.1 in you package.json and it will crash npm while doing npm i

@apollo/client version

3.12.3

@jerelmiller
Copy link
Member

Hey @ruizmarc 👋

We'll need to evaluate the changes in v6 to make sure they are compatible with the current implementation of GraphQLWsLink before we can bump the dependency. I can't give a specific time frame on when we will be able to do this as we have a few higher priority things at the moment. Thanks for bringing this to our attention!

@phryneas
Copy link
Member

phryneas commented Feb 5, 2025

I did evaluate v6, and while there were a few problematic changes to the types, I contacted the author and they have been rolled back in 6.0.3 - we will add compatibility to that version soon.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants