Search code, repositories, users, issues, pull requests...

Less: Fix formatting of `:extend` (#7984 by @fisker)

// Input
.class {
  &:extend(.some-class .some-other-class .some-very-loooooooooooooong-class all);
}

// Prettier 2.0.4
.class {
  &:extend(
    .some-class .some-other-class .some-very-loooooooooooooong-class all
  );
}

// Prettier 2.0.4 (Second format)
.class {
  &: extend(
    .some-class .some-other-class .some-very-loooooooooooooong-class all
  );
}

// Prettier 2.0.5
.class {
  &:extend(
    .some-class .some-other-class .some-very-loooooooooooooong-class all
  );
}

Editor integration: Use `resolve` if builtin `require.resolve` is overridden (#8072 by @fisker)

This fixes issues that the users of Atom and WebStorm faced with 2.0.4.

Prettier now switches to using the resolve module for resolving configuration files and plugins if it detects that require.resolve isn't Node's builtin function (doesn't support the second argument), which happens in environments like editor extensions. To force the fallback, set the PRETTIER_FALLBACK_RESOLVE environment variable to true.

`v2.0.4`

Revert #7869, "[TypeScript] format TSAsExpression with same logic as BinaryExpression" (#7958)

`v2.0.3`

JavaScript

Fix `prettier-ignore` inside JSX (#7877 by @fisker)

// Input
<div>
{
  /* prettier-ignore */
  x     ?   <Y/> : <Z/>
}
</div>;

// Prettier 2.0.2 (first output)
<div>
  {/* prettier-ignore */
  x     ?   <Y/> : <Z/>}
</div>;

// Prettier 2.0.2 (second output)
<div>{/* prettier-ignore */ x     ?   <Y/> : <Z/>}</div>;

// Prettier 2.0.3
<div>
  {
    /* prettier-ignore */
    x     ?   <Y/> : <Z/>
  }
</div>;

Fix regressions in styled-components template literals (#7883 by @thorn0)

// Input
const Icon = styled.div`
  background:   var(--${background});
  ${Link}:not(:first-child) {
      fill:    rebeccapurple;
  }
`;

// Prettier 2.0.2
const Icon = styled.div`
  background: var(-- ${background});
  ${Link}:not (:first-child) {
    fill: rebeccapurple;
  }
`;

// Prettier 2.0.3
const Icon = styled.div`
  background: var(--${background});
  ${Link}:not(:first-child) {
    fill: rebeccapurple;
  }
`;

Fix: line endings were not always converted properly in multiline strings and comments (#7891 by @sidharthv96)

// Input
export const IAmIncredibleLongFunctionName = IAmAnotherFunctionName(<CRLF>
  (_0: IAmIncredibleLongParameterType) => {<CRLF>
    setTimeout(() => {<CRLF>
      /*<CRLF>
        Multiline comment<CRLF>
        Multiline comment<CRLF>
        Multiline comment<CRLF>
      */<CRLF>
      console.log(<CRLF>
        "Multiline string\<CRLF>
         Multiline string\<CRLF>
         Multiline string"<CRLF>
      );<CRLF>
    });<CRLF>
  }<CRLF>
);<CRLF>

// Prettier 2.0.2
export const IAmIncredibleLongFunctionName = IAmAnotherFunctionName(<CRLF>
  (_0: IAmIncredibleLongParameterType) => {<CRLF>
    setTimeout(() => {<CRLF>
      /*<LF>
        Multiline comment<LF>
        Multiline comment<LF>
        Multiline comment<LF>
      */<CRLF>
      console.log(<CRLF>
        "Multiline string\<LF>
         Multiline string\<LF>
         Multiline string"<CRLF>
      );<CRLF>
    });<CRLF>
  }<CRLF>
);<CRLF>

// Prettier 2.0.3: same as input

Fix bug with holes in array literals (#7911 by @bakkot)

// Input
new Test()
  .test()
  .test([, 0])
  .test();

// Prettier 2.0.2
[error] in.js: TypeError: Cannot read property 'type' of null

// Prettier 2.0.3
new Test().test().test([, 0]).test();

TypeScript

Wrap TSAsExpression (#7869 by @sosukesuzuki)

// Input
const value = thisIsAnIdentifier as ThisIsAReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyLongInterface;

// Prettier 2.0.2
const value = thisIsAnIdentifier as ThisIsAReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyLongInterface;

// Prettier 2.0.3
const value =
  thisIsAnIdentifier as
  ThisIsAReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyLongInterface;

Flow

Print dangling comments for inexact object type (#7892 by @sosukesuzuki)

// Input
type Foo = {
  // comment
  ...,
};

// Prettier 2.0.2
Error: Comment "comment" was not printed. Please report this error!

// Prettier 2.0.3
type Foo = {
  // comment
  ...,
};

Do not add comma for explicit inexact object with indexer property or no properties (#7923 by @DmitryGonchar)

// Input
type T = {
  [string]: number,
  ...,
}

type T = {
  // comment
  ...,
}

// Prettier 2.0.2
type T = {
  [string]: number,
  ...,
}

type T = {
  // comment
  ...,
}

// Prettier 2.0.3
type T = {
  [string]: number,
  ...
}

type T = {
  // comment
  ...
}

HTML

Fix printing of ignored empty inline elements (#7867 by @fisker)

<!-- Input-->
<!--prettier-ignore--><span></span>
<!--prettier-ignore--><span>_</span>

<!-- Prettier 2.0.2 (first output) -->
<!--prettier-ignore--><span
></span>
<!--prettier-ignore--><span>_</span>

<!-- Prettier 2.0.2 (second output) -->
<!--prettier-ignore--><span

></span>
<!--prettier-ignore--><span>_</span>

<!-- Prettier 2.0.3 -->
<!--prettier-ignore--><span></span>
<!--prettier-ignore--><span>_</span>

Format `script` and `style` inside tags with a colon in the name (#7916 by @fisker)

<!-- Input -->
<with:colon>
<script>function foo(){      return 1}</script>
<style>a         {color:         #f00}</style>
</with:colon>

<!-- Prettier 2.0.2 -->
<with:colon>
  <script>
    function foo(){ return 1}
  </script>
  <style>
    a {color: #f00}
  </style>
</with:colon>

<!-- Prettier 2.0.3 -->
<with:colon>
  <script>
    function foo() {
      return 1;
    }
  </script>
  <style>
    a {
      color: #f00;
    }
  </style>
</with:colon>

Other changes

Workaround for require.resolve in prettier-vscode (#7951 by @thorn0)
Fix unstable Angular expression binding (#7924 by @fisker)
Update isSCSS regex (#7922 by @fisker)
Fix formatting of empty files (#7921 by @fisker)

`v2.0.2`

2.0 regressions

JavaScript: Fix formatting of pseudo-elements and pseudo-classes in styled-components template literals (#7842 by @thorn0)

// Input
const Foo = styled.div`
  ${media.smallDown}::before {}
`;

// Prettier 2.0.0
const Foo = styled.div`
  ${media.smallDown}: : before{
  }
`;

// Prettier 2.0.2
const Foo = styled.div`
  ${media.smallDown}::before {
  }
`;

TypeScript: Avoid trailing commas on index signatures with only one parameter (#7836 by @bakkot)

TypeScript index signatures technically allow multiple parameters and trailing commas, but it's an error to have multiple parameters there, and Babel's TypeScript parser does not accept them. So Prettier now avoids putting a trailing comma there when you have only one parameter.

// Input
export type A = {
  a?: {
    [
      x: string
    ]: typeof SomeLongLongLongTypeName[keyof typeof SomeLongLongLongTypeName];
  } | null;
};

// Prettier 2.0.0
export type A = {
  a?: {
    [
      x: string,
    ]: typeof SomeLongLongLongTypeName[keyof typeof SomeLongLongLongTypeName];
  } | null;
};

// Prettier 2.0.2
export type A = {
  a?: {
    [
      x: string
    ]: typeof SomeLongLongLongTypeName[keyof typeof SomeLongLongLongTypeName];
  } | null;
};

Revert "markdown: fix redundant leading spaces in markdown list" (#7847)

See #7846

Other changes

TypeScript: Fix `prettier-ignore` in union types (#7798 by @thorn0)

// Input
export type a =
  // foo
  | foo1&foo2
  // prettier-ignore
  | bar1&bar2
  // baz
  | baz1&baz2;

// Prettier 2.0.0
export type a =
  // foo
  | foo1&foo2
    // prettier-ignore
  // prettier-ignore
  | (bar1 & bar2)
  // baz
  | (baz1 & baz2);

// Prettier 2.0.2
export type a =
  // foo
  | (foo1 & foo2)
  // prettier-ignore
  | bar1&bar2
  // baz
  | (baz1 & baz2);

`v2.0.1`

API: Fix build script to not corrupt `import-fresh` module (#7820 by @thorn0)

`v2.0.0`

`v1.19.1`

CLI

Fix `--stdin` regression in 1.19.0 (#6894 by @lydell)

// Prettier stable
$ echo "test" | prettier --stdin --parser babel
[error] regeneratorRuntime is not defined

// Prettier master
$ echo "test" | prettier --stdin --parser babel
test;

TypeScript

Fix formatting of union type as arrow function return type (#6896 by @thorn0)

// Input
export const getVehicleDescriptor = async (
  vehicleId: string,
): Promise<Collections.Parts.PrintedCircuitBoardAssembly['attributes'] | undefined> => {}

// Prettier stable
export const getVehicleDescriptor = async (
  vehicleId: string
): Promise<| Collections.Parts.PrintedCircuitBoardAssembly["attributes"]
| undefined> => {};

// Prettier master
export const getVehicleDescriptor = async (
  vehicleId: string
): Promise<
  Collections.Parts.PrintedCircuitBoardAssembly["attributes"] | undefined
> => {};

`v1.19.0`

`v1.18.2`

TypeScript: only add trailing commas in tuples for --trailing-comma=all ([#6199] by @duailibe)

In Prettier 1.18 we added trailing commas in tuples when --trailing-comma=all, but it was also adding for --trailing-comma=es5.

[#6199]: #6199

@duailibe: https://github.com/duailibe

`v1.18.1`

TypeScript: Add trailing comma in tsx, only for arrow function (#6190 by @sosukesuzuki)

Prettier inserts a trailing comma to single type parameter for arrow functions in tsx, since v 1.18. But, this feature inserts a trailing comma to type parameter for besides arrow functions too (e.g, function , interface). This change fix it.

// Input
interface Interface1<T> {
  one: "one";
}
function function1<T>() {
  return "one";
}

// Output (Prettier 1.18.0)
interface Interface1<T,> {
  one: "one";
}
function function1<T,>() {
  return "one";
}

// Output (Prettier 1.18.1)
interface Interface1<T> {
  one: "one";
}
function function1<T>() {
  return "one";
}

Config: Match dotfiles in config overrides (#6194 by @duailibe)

When using overrides in the config file, Prettier was not matching dotfiles (files that start with .). This was fixed in 1.18.1

`v1.18.0`

`v1.17.1`

Range: Fix ranged formatting not using the correct line width (#6050 by @mathieulj)

// Input
function f() {
  if (true) {
    call("this line is 79 chars", "long", "it should", "stay as single line");
  }
}

// Output (Prettier 1.17.0 run with --range-start 30 --range-end 110)
function f() {
  if (true) {
    call(
      "this line is 79 chars",
      "long",
      "it should",
      "stay as single line"
    );
  }
}

// Output (Prettier 1.17.0 run without range)
function f() {
  if (true) {
    call("this line is 79 chars", "long", "it should", "stay as single line");
  }
}

// Output (Prettier 1.17.1 with and without range)
function f() {
  if (true) {
    call("this line is 79 chars", "long", "it should", "stay as single line");
  }
}

JavaScript: Fix closure compiler typecasts ([#5947] by @jridgewell)

If a closing parenthesis follows after a typecast in an inner expression, the typecast would wrap everything to the that following parenthesis.

// Input
test(/** @&#8203;type {!Array} */(arrOrString).length);
test(/** @&#8203;type {!Array} */((arrOrString)).length + 1);

// Output (Prettier 1.17.0)
test(/** @&#8203;type {!Array} */ (arrOrString.length));
test(/** @&#8203;type {!Array} */ (arrOrString.length + 1));

// Output (Prettier 1.17.1)
test(/** @&#8203;type {!Array} */ (arrOrString).length);
test(/** @&#8203;type {!Array} */ (arrOrString).length + 1);

JavaScript: respect parenthesis around optional chaining before await (#6087 by @evilebottnawi)

// Input
async function myFunction() {
  var x = (await foo.bar.blah)?.hi;
}

// Output (Prettier 1.17.0)
async function myFunction() {
  var x = await foo.bar.blah?.hi;
}

// Output (Prettier 1.17.1)
async function myFunction() {
  var x = (await foo.bar.blah)?.hi;
}

Handlebars: Fix {{else}}{{#if}} into {{else if}} merging (#6080 by @dcyriller)

// Input
{{#if a}}
  a
{{else}}
  {{#if c}}
    c
  {{/if}}
  e
{{/if}}

// Output (Prettier 1.17.0)
{{#if a}}
  a
{{else if c}}
  c
e
{{/if}}

// Output (Prettier 1.17.1)
Code Sample
{{#if a}}
  a
{{else}}
  {{#if c}}
    c
  {{/if}}
  e
{{/if}}

JavaScript: Improved multiline closure compiler typecast comment detection (#6070 by @yangsu)

Previously, multiline closure compiler typecast comments with lines that
start with * weren't flagged correctly and the subsequent parenthesis were
stripped. Prettier 1.17.1 fixes this issue.

// Input
const style =/**
 * @&#8203;type {{
 *   width: number,
 * }}
*/({
  width,
});

// Output (Prettier 1.17.0)
const style =/**
 * @&#8203;type {{
 *   width: number,
 * }}
*/ {
  width,
};

// Output (Prettier 1.17.1)
const style =/**
 * @&#8203;type {{
 *   width: number,
 * }}
*/({
  width,
});

`v1.17.0`

`v1.16.4`

API: Fix prettier.getSupportInfo() reporting babel parser for older versions of Prettier. (#5826 by @azz)

In version 1.16.0 of Prettier, the babylon parser was renamed to babel. Unfortunately this lead to a minor breaking change: prettier.getSupportInfo('1.15.0') would report that it supported babel, not babylon, which breaks text-editor integrations. This has now been fixed.

`v1.16.3`

TypeScript: Revert "Update typescript-estree to new package name" (#5818 by @ikatyang)

There's an internal change introduced in Prettier 1.16.2,
which updated typescript-estree to its new package name,
but unfortunately it broke the output
so we reverted it as a temporary workaround for now.

// Input
export default {
  load<K, T>(k: K, t: T) {
    return {k, t};
  }
}

// Output (Prettier 1.16.2)
export default {
  load(k: K, t: T) {
    return { k, t };
  }
};

// Output (Prettier 1.16.3)
export default {
  load<K, T>(k: K, t: T) {
    return { k, t };
  }
};

`v1.16.2`

CLI: Fix CI detection to avoid unwanted TTY behavior (#5804 by @kachkaev)

In Prettier 1.16.0 and 1.16.1, --list-different and --check logged every file in some CI environments, instead of just unformatted files.
This unwanted behavior is now fixed.
HTML: Do not format non-normal whitespace as normal whitespace (#5797 by @ikatyang)

Previously, only non-breaking whitespaces (U+00A0) are marked as non-normal whitespace,
which means other non-normal whitespaces such as non-breaking narrow whitespaces (U+202F)
could be formatted as normal whitespaces, which breaks the output. We now follow the spec to
exclude all non-ASCII whitespace from whitespace normalization.

(· represents a non-breaking narrow whitespace)
```

Prix·:·32·€


Prix : 32 €


Prix·:·32·€
```

JavaScript: Fix record type cast comment detection (#5793 by @yangsu)

Previously, type cast comments with record types were ignored and prettier
stripped the subsequent parens. Prettier 1.16.2 handles these cases correctly.

// Input
const v = /** @&#8203;type {{key: number}} */ (value);

// Output (Prettier 1.16.1)
const v = /** @&#8203;type {{key: number}} */ value;

// Output (Prettier 1.16.2)
const v = /** @&#8203;type {{key: number}} */ (value);

`v1.16.1`

JavaScript: Do not format functions with arguments as react hooks (#5778 by @SimenB)

The formatting added in Prettier 1.16 would format any function receiving an
arrow function and an array literal to match React Hook's documentation.
Prettier will now format this the same as before that change if the arrow
function receives any arguments.

// Input
["red", "white", "blue", "black", "hotpink", "rebeccapurple"].reduce(
  (allColors, color) => {
    return allColors.concat(color);
  },
  []
);

// Output (Prettier 1.16.0)
["red", "white", "blue", "black", "hotpink", "rebeccapurple"].reduce((
  allColors,
  color
) => {
  return allColors.concat(color);
}, []);

// Output (Prettier 1.16.1)
["red", "white", "blue", "black", "hotpink", "rebeccapurple"].reduce(
  (allColors, color) => {
    return allColors.concat(color);
  },
  []
);

JavaScript: Add necessary parentheses for decorators (#5785 by @ikatyang)

Parentheses for decorators with nested call expressions are optional for legacy decorators
but they're required for decorators in the current proposal.

// Input
class X {
  @&#8203;(computed().volatile())
  prop
}

// Output (Prettier 1.16.0)
class X {
  @&#8203;computed().volatile()
  prop
}

// Output (Prettier 1.16.1)
class X {
  @&#8203;(computed().volatile())
  prop
}

TypeScript: Stable parentheses for function type in the return type of arrow function (#5790 by @ikatyang)

There's a regression introduced in 1.16 that
parentheses for function type in the return type of arrow function were kept adding/removing.
Their parentheses are always printed now.

// Input
const foo = (): (() => void) => (): void => null;
const bar = (): () => void => (): void => null;

// First Output (Prettier 1.16.0)
const foo = (): () => void => (): void => null;
const bar = (): (() => void) => (): void => null;

// Second Output (Prettier 1.16.0)
const foo = (): (() => void) => (): void => null;
const bar = (): () => void => (): void => null;

// Output (Prettier 1.16.1)
const foo = (): (() => void) => (): void => null;
const bar = (): (() => void) => (): void => null;

MDX: Correctly recognize inline JSX (#5783 by @ikatyang)

Previously, some inline JSXs are wrongly recognized as block HTML/JSX,
which causes unexpected behaviors. This issue is now fixed.
```

_foo <InlineJSX /> bar_


_foo

<InlineJSX /> bar_


_foo <InlineJSX /> bar_
```

`v1.16.0`

`v1.15.3`