-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package missing error after install. #1065
Comments
Are you directly importing If you were directly depending on |
I am using Nestjs while using their Graphql module, I have left them a bug report as well, I've checked node_modules and yes the error message is correct there's no directives file. Here's the repo - https://github.com/OGNeutron/TheLastHurrah/tree/master/packages/the-last-hurrah-commence |
The file is definitely gone, so the error message is correct. My point is that we didn't expect anyone to depend on it externally from the project, as it's not exported from the top-level of the package. 😉 If someone is — that's okay though it'd be good to understand the use-cases, so we can discuss if we want to expose it at the top-level of the package or not! In the meanwhile, the dependency should be updated to point to That module is now available at |
I responded on https://github.com/nestjs/nest/issues/8264 and linked it to this issue for others who encounter this. This will need to be fixed in NestJS though! |
Odd, I don't think I changed anything, I had a problem with Prisma JS so I re-installed all the node_modules in the workspace fixed that problem then this random problem popped up, so someone has changed something. I agree it's probably on Nestjs end which I have left messages on their Discord and Github, just waiting for them to respond, I am guessing it's just a change they made. Thanks for the help. |
To be clear: Something has changed. It isn't something they have changed, but rather something we changed. However, the thing we changed isn't something another external project was meant to be depending on. Because they did depend on it (a deeply nested module; a function that is not part of our public API) — now they need to make a change. I don't know much about how NestJs works, but I'm assuming that after they fix things, you should be all set again without making any changes. 😄 |
This is being resolved in nestjs/graphql#1797 (and follow-ups) |
@abernix for future reference, since |
@iMobs It seems plausible to me! You should be fine for the short-term, but can you elaborate on the use-cases so we can talk about them explicitly and make sure we make the right choice? Thanks! |
@iMobs happy to discuss possibly exporting these directives as part of the public API. Would you mind opening an issue (or a PR, even) which states your use case for them? |
@trevor-scheer type-graphql's example federation project uses this to make a schema https://github.com/MichalLytek/type-graphql/blob/master/examples/apollo-federation/helpers/buildFederatedSchema.ts |
Looks like the owner of NestJS has done a major refactor and referencing the directives is no longer an issue. AFAIK this was a fork of type-graphql and I'm not sure how much they learn from each other these days but a similar fix would probably be a good idea. |
I've been getting this error for some reason -
The "@apollo/federation/dist/directives" package is missing. Please, make sure to install this library ($ npm install @apollo/federation/dist/directives) to take advantage of SchemaBuilder
The text was updated successfully, but these errors were encountered: